RussellSpitzer commented on a change in pull request #2508:
URL: https://github.com/apache/iceberg/pull/2508#discussion_r635690823
##########
File path:
core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -277,6 +279,15 @@ private void replaceDataFiles(Iterable<DataFile>
deletedDataFiles, Iterable<Data
}
}
+ private boolean isSingleBigFile(Map.Entry<StructLikeWrapper,
Collection<FileScanTask>> kv) {
Review comment:
This should be fine just taking a single FileScanTask as an arg right?
Since we only call this method on a single FileScan task to see if it is
splittable?
I would probably also say
isSplittable(FileScanTask file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
