rdblue commented on a change in pull request #2621:
URL: https://github.com/apache/iceberg/pull/2621#discussion_r637228203
##########
File path:
core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -267,7 +268,10 @@ private void replaceDataFiles(Iterable<DataFile>
deletedDataFiles, Iterable<Data
RewriteFiles rewriteFiles = table.newRewrite();
rewriteFiles.rewriteFiles(Sets.newHashSet(deletedDataFiles),
Sets.newHashSet(addedDataFiles));
commit(rewriteFiles);
- } catch (Exception e) {
+ } catch (CommitStateUnknownException e) {
+ LOG.warn("Skip delete files because we can not determine whether the
commit was successful or not.");
Review comment:
I think this error message could be a little more clear. We try to write
these in a form like "Cause: result". In this case, I'd recommend "Failed to
check commit status: skipping data file deletion".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
