zhangjun0x01 commented on issue #2558: URL: https://github.com/apache/iceberg/issues/2558#issuecomment-846928291
> I did few tests to verify whether the iceberg-flink-runtime jar (compiled in flink 1.12 ) could work in flink 1.13, sounds like the only one issue is [CatalogDescriptorValidator](https://github.com/apache/iceberg/blob/master/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java#L31), it's an `Internal` API but has been removed in flink 1.13. I think we could remove the usage about `Internal` API then we could make this jar work in both flink 1.12 and flink 1.13, don't have to upgrade this version to flink 1.13. I tested that, if we upgrade to flink 1.13 ，and all UT have passed, some methods of `FlinkCatalogFactory` need to be modified, because `org.apache.flink.table.factories.CatalogFactory` interface of flink has changed, the specific code refers to this branch: https://github.com/zhangjun0x01/iceberg/ tree/flink1.13 。 I think it is difficult to be compatible with flink 1.12 and 1.13 at the same time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
