rymurr commented on a change in pull request #2286: URL: https://github.com/apache/iceberg/pull/2286#discussion_r639541557
########## File path: arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ColumnVector.java ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.arrow.vectorized; + +import org.apache.arrow.vector.FieldVector; +import org.apache.iceberg.types.Types; + +/** + * This class is inspired by Spark's {@code ColumnVector}. + * This class represents the column data for an Iceberg table query. + * It wraps an arrow {@link FieldVector} and provides simple + * accessors for the row values. Advanced users can access + * the {@link FieldVector}. + * <p> + * Supported Iceberg data types: + * <ul> + * <li>{@link Types.BooleanType}</li> + * <li>{@link Types.IntegerType}</li> + * <li>{@link Types.LongType}</li> + * <li>{@link Types.FloatType}</li> + * <li>{@link Types.DoubleType}</li> + * <li>{@link Types.StringType}</li> + * <li>{@link Types.BinaryType}</li> + * <li>{@link Types.TimestampType} (with and without timezone)</li> + * <li>{@link Types.DateType}</li> + * </ul> + */ +public class ColumnVector implements AutoCloseable { Review comment: > My concern is that we're introducing a new API that is specific to Iceberg and will need to be supported for a long time. This was my concern as well. I figured that a new api was better than having to be coupled to any changes arrow may make. At least we have control over how this API will evolve. Perhaps some javadoc to that point and to clearly state the intention of this API? The other goal I had was to assist the user of this API with Arrow buffer lifetime/usage, which I have found to be finicky on occasion. I don't think Iceberg users should require knowledge of Arrow Vectors just to use the vectorised readers. Having said that I don't feel that strong and if the feeling in the community is its not a useful abstraction then I happily agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
