kbendick commented on a change in pull request #2641:
URL: https://github.com/apache/iceberg/pull/2641#discussion_r640322831
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergOutputCommitter.java
##########
@@ -232,7 +232,7 @@ public void abortJob(JobContext originalContext, int
status) throws IOException
.executeWith(tableExecutor)
.onFailure((output, exc) -> LOG.warn("Failed cleanup table {} on
abort job", output, exc))
.run(output -> {
- LOG.info("Cleaning job for table {}", jobContext.getJobID(),
output);
+ LOG.info("Cleaning job for table {} {}", jobContext.getJobID(),
output);
Review comment:
Good catch 👍.
I seem to remember there being some sort of analyzer annotation or something
to ensure the correct number of arguments, but for the life of me I can't
recall right now. Probably wouldn't be related to this case.
EDIT: You don't need to use it, but for your reference this is what I was
thinking of. It and some other annotations in the same package provides compile
time checking on format strings:
https://errorprone.info/api/latest/com/google/errorprone/annotations/FormatMethod.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
