StefanXiepj commented on a change in pull request #2649:
URL: https://github.com/apache/iceberg/pull/2649#discussion_r641778727
##########
File path: core/src/main/java/org/apache/iceberg/ClientPoolImpl.java
##########
@@ -36,6 +38,10 @@
private volatile int currentSize;
private boolean closed;
+ private static volatile AtomicInteger openCount = new AtomicInteger(0);
Review comment:
Thanks for your time, yes your right, it's the total number of
connections ever opened and the total number of connections closed，just for
unit test, maybe the log is also useful.
As @southernriver suggested, closed directly would be better. it is no
need to wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
