szlta commented on a change in pull request #2613:
URL: https://github.com/apache/iceberg/pull/2613#discussion_r642430232
##########
File path: build.gradle
##########
@@ -551,6 +551,60 @@ project(':iceberg-mr') {
}
if (jdkVersion == '8') {
+ // The purpose of this module is to re-shade org.apache.orc.storage to the
original org.apache.hadoop.hive package
+ // name. This is to be used by Hive3 for features including e.g.
vectorization.
+ project(':iceberg-hive3-orc-bundle') {
Review comment:
Thanks for taking a look on this @rymurr!
Originally I wanted to stick to not modifying any code snippets that needs
to be copied from Hive to Iceberg as it's meant to be temporary. But.. since I
don't see Hive4 getting released in the foreseeable future yet I have now
rather amended these as per checkstyle.
About this hive3-orc-bundle: it's something that only hive3 depends on, and
the soul purpose of it is to re-shade hive-storage-api classes that are
currently being referred to as org.apache.orc.storage... within Iceberg.
This bundle will produce iceberg-data, and iceberg-orc classes with the
original package name references to storage-api classes which is required
runtime, where Hive3 code (from Hive codebase) is already linked with the
original class names.
The reason this is not a dependency of iceberg-mr module, is that we won't
support vectorization for the Hive2 integration of Iceberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
