rdblue commented on a change in pull request #2275:
URL: https://github.com/apache/iceberg/pull/2275#discussion_r642706533
##########
File path: core/src/test/java/org/apache/iceberg/TestTableMetadata.java
##########
@@ -93,12 +93,11 @@ public void testJsonConversion() throws Exception {
new GenericManifestFile(localInput("file:/tmp/manfiest.1.avro"),
SPEC_5.specId())));
long currentSnapshotId = System.currentTimeMillis();
Snapshot currentSnapshot = new BaseSnapshot(
- ops.io(), currentSnapshotId, previousSnapshotId, currentSnapshotId,
null, null, ImmutableList.of(
+ ops.io(), currentSnapshotId, previousSnapshotId, currentSnapshotId,
null, null, 7, ImmutableList.of(
new GenericManifestFile(localInput("file:/tmp/manfiest.2.avro"),
SPEC_5.specId())));
List<HistoryEntry> snapshotLog = ImmutableList.<HistoryEntry>builder()
.add(new SnapshotLogEntry(previousSnapshot.timestampMillis(),
previousSnapshot.snapshotId()))
- .add(new SnapshotLogEntry(currentSnapshot.timestampMillis(),
currentSnapshot.snapshotId()))
Review comment:
Why is this entry no longer present?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
