bkahloon commented on pull request #2282:
URL: https://github.com/apache/iceberg/pull/2282#issuecomment-851784050


   Hi @daniil-dubin , sorry for the delay. According to @RussellSpitzer 
comments, you will need to add an additional case statement handling the 
timestamp without timezone writing operation. For example for the [orc spark 
writer 
](https://github.com/RussellSpitzer/iceberg/blob/8e026f140b4e5d213083e57321d8bdc312650a6f/spark/src/main/java/org/apache/iceberg/spark/data/SparkOrcWriter.java#L120-L121)
 you can add in an additional statement for without timezone. Russell also 
mentioned that you should probably add in the warning flag like we did in this 
PR. If you see this [piece of 
code](https://github.com/apache/iceberg/pull/2282/files#diff-47b9fbed0d32a8f8ec128a4f78cd93f238e65c38f93e9a10d257eb83838563ffR93-R99)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to