rymurr commented on a change in pull request #2655:
URL: https://github.com/apache/iceberg/pull/2655#discussion_r643033058
##########
File path: python/iceberg/api/expressions/literals.py
##########
@@ -243,6 +260,9 @@ def to(self, type_var):
.quantize(Decimal("." + "".join(["0" for
i in range(1, type_var.scale)]) + "1"),
rounding=ROUND_HALF_UP))
+ def type_id(self):
Review comment:
Why would it affect other files? To me it would just make this diff
smaller: add `type_id` parameter to `__init__` and return it instead of the
`NotImplementedError` in `BaseLiteral.type_id`, then we don't have to implement
`def type_id(self):` in every subclass.
But yeah, not overly precious about it. Can def be done in a followup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
