rymurr commented on a change in pull request #2662:
URL: https://github.com/apache/iceberg/pull/2662#discussion_r643780181
##########
File path:
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java
##########
@@ -103,7 +103,7 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
boolean delete = true;
try {
IcebergTable newTable =
ImmutableIcebergTable.builder().metadataLocation(newMetadataLocation).build();
- Builder cm = CommitMeta.builder().message("iceberg commit");
+ ImmutableCommitMeta.Builder cm = CommitMeta.builder().message("iceberg
commit").author("iceberg");
Review comment:
to me `iceberg` is better in the properties map as `application.type` or
so. The author should be the person performing the action, so either the
spark/os user or the user logged into Nessie. The later is done already by the
server and I think is more reliable than the spark/os user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
