nastra commented on a change in pull request #2664:
URL: https://github.com/apache/iceberg/pull/2664#discussion_r644048571
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -80,12 +79,14 @@
private UpdateableReference reference;
private String name;
private FileIO fileIO;
+ private Map<String, String> catalogOptions;
public NessieCatalog() {
}
@Override
public void initialize(String inputName, Map<String, String> options) {
+ this.catalogOptions = ImmutableMap.copyOf(options);
Review comment:
Assuming Spark is configured such as in
https://github.com/projectnessie/nessie-demos/blob/main/pydemolib/nessiedemo/iceberg_spark.py#L67-L73
I believe we should end up in `SparkSessionCatalog` / `SparkCatalog` first
(where those spark options are being set) and then those options are just being
passed down to the respective `catalog-impl` class if I read the implementation
correctly in `SparkCatalog#initialize(...)` ->
`SparkCatalog#buildIcebergCatalog(...)` ->
`CatalogUtil.buildIcebergCatalog(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
