RussellSpitzer commented on a change in pull request #2660:
URL: https://github.com/apache/iceberg/pull/2660#discussion_r647563081
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/source/StreamingOffset.java
##########
@@ -132,4 +130,18 @@ public String toString() {
return String.format("Streaming Offset[%d: position (%d) scan_all_files
(%b)]",
snapshotId, position, scanAllFiles);
}
+
+ private static StreamingOffset fromJsonNode(JsonNode node) {
+ // The version of StreamingOffset. The offset was created with a version
number
+ // used to validate when deserializing from json string.
+ int version = JsonUtil.getInt(VERSION, node);
+ Preconditions.checkArgument(version == CURR_VERSION,
+ "Cannot parse offset JSON: offset version %s is not supported",
version);
Review comment:
Should add "This version of Iceberg only supports version CURR_VERSION"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
