kbendick commented on pull request #2595: URL: https://github.com/apache/iceberg/pull/2595#issuecomment-858082399
> > @kbendick got this error > > ``` > > Execution failed for task ':iceberg-spark2:jmh'. > > > A failure occurred while executing me.champeau.gradle.IsolatedRunner > > > Error during execution of benchmarks > > ``` > > > > > > > > > > > > > > > > > > > > > > > > When i ran > > `g jmh` > > on the pr > > So just like the current set up (as far as I'm aware), you have to specify the actual test to be run. So something like the following, as mentioned in the existing code [here](https://github.com/apache/iceberg/pull/2595/files#diff-ed844daf9dae5835b7ed247c21439af720df778c28596c644a9da8d7013f4fb9L56-L58) > > ``` > ./gradlew :iceberg-spark2:jmh \ > -PjmhIncludeRegex=SparkParquetWritersNestedDataBenchmark \ > -PjmhOutputPath=benchmark/spark-parquet-writers-nested-data-benchmark-result.txt > ``` > > I will test simply `./gradlew jmh` on the current state of master vs my PR, but with my PR, the tests run the same way as mentioned in the doc comments of each test. @RussellSpitzer I tried running `./gradlew jmh` both from master and from my branch. Both of them failed eventually, but after running for 20-25 minutes and completing at least 3-4 of the benchmarks each time. @RussellSpitzer has now been able to get plain `./gradle jmh` to run for over an hour now on this PR branch. When I run an individual test, as recommended in the comments of each test (or above), it runs just fine to completion. I think it's more an issue with gradle JVM settings and then running out of memory or other resources, possibly with the number of forked threads when running all of the benchmarks for all of the requested iterations. **TLDR:** I don't think we should run `jmh` itself to run _all_ tests without better configuring gradle. But stick to running the tests as they're mentioned in the test comments. This does not introduce any new issues with the JMH tests, other than possibly the added number of tests if one runs `./gradlew jmh` by itself (which is not guaranteed to run to completion anyway with the current state in master). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
