aokolnychyi commented on a change in pull request #2591:
URL: https://github.com/apache/iceberg/pull/2591#discussion_r649357518
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -162,4 +163,27 @@ private void validateOptions() {
"Cannot set %s is less than 1. All values less than 1 have the same
effect as 1. %d < 1",
MIN_INPUT_FILES, minInputFiles);
}
+
+ protected long targetFileSize() {
+ return this.targetFileSize;
+ }
+
+ /**
+ * Ideally every Spark Task that is generated will be less than or equal to
our target size but
Review comment:
I think the first sentence should be little bit more clear that we
estimate the tasks correctly and we hope the generated file (not task) will be
less than or equal to our target file size...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
