aokolnychyi commented on a change in pull request #2591:
URL: https://github.com/apache/iceberg/pull/2591#discussion_r649433302
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/source/SparkFilesScan.java
##########
@@ -62,6 +63,9 @@
long tableSplitSize = PropertyUtil.propertyAsLong(props, SPLIT_SIZE,
SPLIT_SIZE_DEFAULT);
this.splitSize = Spark3Util.propertyAsLong(options,
SparkReadOptions.SPLIT_SIZE, tableSplitSize);
+ Preconditions.checkArgument(splitSize > 0,
Review comment:
I think we better move this validation to `TableScanUtil` and also
validate other args such as `lookback`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
