sshkvar commented on pull request #2282: URL: https://github.com/apache/iceberg/pull/2282#issuecomment-859609110
@RussellSpitzer thank you for the response, changes are ready, but I can't push to the current git branch, so I created another [PR to my forked version of iceberg]( https://github.com/sshkvar/iceberg/pull/1/files) I can create PR to original Iceberg repository or @bkahloon can pull my changes to the current branch. What is the process for such cases? Short description about changes: Added a new spark session config `spark.sql.iceberg.handle-timestamp-without-timezone` which is responsible for allowing reading/writing timestamps without timezone, the same as reader/writer config `spark-handle-timestamp-without-timezone`. Also added additional spark session config `spark.sql.iceberg.store-timestamp-without-zone` which is responsible for indicating which iceberg type `TimestampType.withoutZone()` or `TimestampType.withZone()` will be used in [SparkTypeToType.java](https://github.com/sshkvar/iceberg/blob/02dfdf892f3d5c4f17392bc436b69b23fdb1da84/spark/src/main/java/org/apache/iceberg/spark/SparkTypeToType.java) @RussellSpitzer @bkahloon I would really appreciate for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
