rdblue commented on a change in pull request #2684:
URL: https://github.com/apache/iceberg/pull/2684#discussion_r650442897
##########
File path:
nessie/src/test/java/org/apache/iceberg/nessie/TestBranchVisibility.java
##########
@@ -22,12 +22,13 @@
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.types.Types;
import org.junit.After;
-import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.projectnessie.error.NessieConflictException;
import org.projectnessie.error.NessieNotFoundException;
+import static org.assertj.core.api.Assertions.assertThat;
Review comment:
Yeah, it would be great to update the checkstyle rule. I'm not sure why
it isn't catching this. Maybe we don't have it applied correctly to tests.
##########
File path: api/src/test/java/org/apache/iceberg/AssertHelpers.java
##########
@@ -20,7 +20,9 @@
package org.apache.iceberg;
import java.util.concurrent.Callable;
-import org.junit.Assert;
+import org.assertj.core.api.AbstractThrowableAssert;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
Review comment:
Can you remove this static import as well?
##########
File path: build.gradle
##########
@@ -124,7 +124,7 @@ subprojects {
testCompile 'junit:junit'
testCompile 'org.slf4j:slf4j-simple'
-
Review comment:
Can you avoid the whitespace change and add this line back? That will
avoid git conflicts.
##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/NessieUtilTest.java
##########
@@ -21,15 +21,19 @@
import org.apache.iceberg.CatalogProperties;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-import org.junit.Assert;
import org.junit.Test;
import org.projectnessie.model.CommitMeta;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
Review comment:
More static imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
