jshmchenxi commented on a change in pull request #2582:
URL: https://github.com/apache/iceberg/pull/2582#discussion_r651396473
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
##########
@@ -195,11 +196,12 @@ private void startRowGroup() {
this.nextCheckRecordCount = Math.min(Math.max(recordCount / 2, 100),
10000);
this.recordCount = 0;
- PageWriteStore pageStore = pageStoreCtorParquet.newInstance(
+ ColumnChunkPageWriteStore pageStore = pageStoreCtorParquet.newInstance(
Review comment:
Hi, I have split this into 2 PRs:
Core: Support writing parquet bloom filter #2642
Core: Support reading parquet bloom filter #2643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
