jackye1995 commented on pull request #2654: URL: https://github.com/apache/iceberg/pull/2654#issuecomment-861728965
trying to remember why we decided to make it optional: https://github.com/apache/iceberg/pull/2465#discussion_r615313057 My current thinking is that it does not hurt to make it optional. If the engine enforces the primary key to be not nullable, it will fail in that engine during CREATE TABLE anyway, just like what we see in Flink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
