rdblue commented on a change in pull request #2603:
URL: https://github.com/apache/iceberg/pull/2603#discussion_r652149820



##########
File path: 
flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSinkV2.java
##########
@@ -337,4 +337,188 @@ private StructLikeSet actualRowSet(long snapshotId, 
String... columns) throws IO
     }
     return set;
   }
+
+  @Test
+  public void testChangeLogOnIdKeyWithSnapshotExpire() throws Exception {

Review comment:
       Since this is updating a file in core, I would expect the tests to be 
more specific and located in core, not in the Flink integration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to