rdblue commented on a change in pull request #2538:
URL: https://github.com/apache/iceberg/pull/2538#discussion_r652270970
##########
File path: core/src/main/java/org/apache/iceberg/avro/ValueReaders.java
##########
@@ -591,6 +591,8 @@ protected StructReader(List<ValueReader<?>> readers, Schema
schema) {
if (AvroSchemaUtil.getFieldId(field) ==
MetadataColumns.ROW_POSITION.fieldId()) {
// track where the _pos field is located for setRowPositionSupplier
this.posField = pos;
+ } else if (AvroSchemaUtil.getFieldId(field) ==
MetadataColumns.IS_DELETED.fieldId()) {
+ this.readers[pos] = new ConstantReader<>(false);
Review comment:
Can you convert this to use positions and constants as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
