SreeramGarlapati commented on a change in pull request #2660:
URL: https://github.com/apache/iceberg/pull/2660#discussion_r655084462



##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -107,4 +122,16 @@ public static boolean ancestorOf(Table table, long 
snapshotId, long ancestorSnap
 
     return newFiles;
   }
+
+  public static int existingDataFilesCount(Snapshot snapshot) {
+    int totalExistingDataFilesCount = 0;
+
+    if (snapshot != null) {
+      for (ManifestFile dataManifest : snapshot.dataManifests()) {
+        totalExistingDataFilesCount += dataManifest.existingFilesCount();

Review comment:
       as I moved implementing fullScan mode OUT of this PR - i marked this for 
future & linked up to the right work item. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to