jackye1995 commented on a change in pull request #2678:
URL: https://github.com/apache/iceberg/pull/2678#discussion_r655873717
##########
File path: core/src/main/java/org/apache/iceberg/util/SerializationUtil.java
##########
@@ -43,6 +45,16 @@ private SerializationUtil() {
}
}
+ public static byte[] serializeToBytesWithHadoopConfig(Object obj) {
Review comment:
The original thinking was that the use of
`org.apache.iceberg.hadoop.SerializableConfiguration` was not always a default.
`SerializableTable` uses a map based serializer, Spark also has its own
serializer. So I don't want the user to blindly assume that `serializeToBytes`
would take care of the Hadoop configuration in all places. If we are making it
a default, then I will add a documentation for `serializeToBytes` to make this
clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
