openinx commented on a change in pull request #2680:
URL: https://github.com/apache/iceberg/pull/2680#discussion_r656735450
##########
File path: build.gradle
##########
@@ -220,6 +220,7 @@ project(':iceberg-core') {
compile "com.fasterxml.jackson.core:jackson-databind"
compile "com.fasterxml.jackson.core:jackson-core"
compile "com.github.ben-manes.caffeine:caffeine"
+ compile "org.rocksdb:rocksdbjni"
Review comment:
As the `StructLikeMap` is in the `core` code path, which don't depend on
any specific compute engines(spark/flink/hive/presto etc), so in theory we
could not assume that the engine runtime will include this dependency jar.
It's better to include it in iceberg's jar if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
