yyanyy commented on a change in pull request #2275:
URL: https://github.com/apache/iceberg/pull/2275#discussion_r658281131
##########
File path: core/src/main/java/org/apache/iceberg/BaseSnapshot.java
##########
@@ -87,7 +91,18 @@
String operation,
Map<String, String> summary,
List<ManifestFile> dataManifests) {
- this(io, INITIAL_SEQUENCE_NUMBER, snapshotId, parentId, timestampMillis,
operation, summary, null);
+ this(io, snapshotId, parentId, timestampMillis, operation, summary, null,
dataManifests);
+ }
+
+ BaseSnapshot(FileIO io,
Review comment:
This was actually me trying to avoid changing a lot of existing code
since there are a lot of usage for the old constructor; but since they are all
in tests and I'd expect less merge conflicts from tests, I think it might be
fine to directly change. Will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
