rdblue commented on pull request #2732: URL: https://github.com/apache/iceberg/pull/2732#issuecomment-868017383
@nastra is your intent to enforce these style rules in CI as well? I think we want to consider whether it is worth making these changes because these will cause commit conflicts when cherry-picking commits before or after this is done. One reason to go ahead and do that is if we intend to enforce the style in CI and conform to it in all cases. I think that is also something we should do if we intend to make these changes. Better style enforcement seems like a good thing in general, as long as we aren't just periodically "fixing" without enforcement. FYI @cwsteinbach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
