RussellSpitzer commented on a change in pull request #2757:
URL: https://github.com/apache/iceberg/pull/2757#discussion_r660712924
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -329,8 +335,10 @@ public boolean enableBatchRead() {
boolean batchReadsEnabled = batchReadsEnabled(allParquetFileScanTasks,
allOrcFileScanTasks);
+ boolean hasTimestampWithoutZone =
SparkUtil.hasTimestampWithoutZone(lazySchema());
+
this.readUsingBatch = batchReadsEnabled && hasNoDeleteFiles &&
(allOrcFileScanTasks ||
- (allParquetFileScanTasks && atLeastOneColumn && onlyPrimitives));
+ (allParquetFileScanTasks && atLeastOneColumn && onlyPrimitives
&& !hasTimestampWithoutZone));
Review comment:
wasI think I noted on the other PR I don't think we need this
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -329,8 +335,10 @@ public boolean enableBatchRead() {
boolean batchReadsEnabled = batchReadsEnabled(allParquetFileScanTasks,
allOrcFileScanTasks);
+ boolean hasTimestampWithoutZone =
SparkUtil.hasTimestampWithoutZone(lazySchema());
+
this.readUsingBatch = batchReadsEnabled && hasNoDeleteFiles &&
(allOrcFileScanTasks ||
- (allParquetFileScanTasks && atLeastOneColumn && onlyPrimitives));
+ (allParquetFileScanTasks && atLeastOneColumn && onlyPrimitives
&& !hasTimestampWithoutZone));
Review comment:
I think I noted on the other PR I don't think we need this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
