rdblue commented on a change in pull request #2752:
URL: https://github.com/apache/iceberg/pull/2752#discussion_r661047078
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkReadOptions.java
##########
@@ -50,4 +50,10 @@ private SparkReadOptions() {
// Set ID that is used to fetch file scan tasks
public static final String FILE_SCAN_TASK_SET_ID = "file-scan-task-set-id";
+
+ // skip snapshots of type delete while reading stream out of iceberg table
+ public static final String READ_STREAM_SKIP_DELETE =
"read-stream-skip-delete";
+
+ // skip snapshots of type replace while reading stream out of iceberg table
+ public static final String READ_STREAM_SKIP_REPLACE =
"read-stream-skip-replace";
Review comment:
Why make this optional? Since replace commits don't affect the logical
data in the table, shouldn't they always be skipped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
