aokolnychyi commented on a change in pull request #2240:
URL: https://github.com/apache/iceberg/pull/2240#discussion_r661090071
##########
File path: core/src/main/java/org/apache/iceberg/MetricsModes.java
##########
@@ -150,6 +150,19 @@ public String toString() {
}
}
+ /**
+ * Auto promote sorted columns to truncate(16) if default is set at Counts
or None.
+ * @param defaultMode default mode
+ * @return mode to use
+ */
+ public static MetricsMode promoteSortedColumnDefault(MetricsMode
defaultMode) {
Review comment:
I'd probably move this into `MetricsConfig` as a private method. Seems
like we only use it there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
