kbendick commented on a change in pull request #2761:
URL: https://github.com/apache/iceberg/pull/2761#discussion_r661768686
##########
File path: python/iceberg/api/expressions/expressions.py
##########
@@ -106,6 +106,15 @@ def equal(name, value):
def not_equal(name, value):
return UnboundPredicate(Operation.NOT_EQ, Expressions.ref(name), value)
+ # In Python we use "startswith", to match the direct conversion & the
pythonic impl do both.
Review comment:
Perhaps I haven't had enough coffee yet, but the ending of this phrase
is hard for me to grok where it says "to match the direct conversion" is a bit
hard for me to grok.
Please correct me if I'm wrong, but I think it means that we use
`starts_with` to match the normal Java Iceberg API of `startsWith`, but allow
for `startswith` to match the python function of the same name. Is that correct?
##########
File path: python/iceberg/api/expressions/expressions.py
##########
@@ -106,6 +106,15 @@ def equal(name, value):
def not_equal(name, value):
return UnboundPredicate(Operation.NOT_EQ, Expressions.ref(name), value)
+ # In Python we use "startswith", to match the direct conversion & the
pythonic impl do both.
Review comment:
After looking at this for a minute, it does not seem pretty clear to me.
Feel free to edit or close this thread at your discretion and I'm gonna make
myself another cup. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
