ismailsimsek edited a comment on issue #2744:
URL: https://github.com/apache/iceberg/issues/2744#issuecomment-872418671


   Thank you @haormj for testing the new feature,
   
   for 2. Error  it seems like we should use reasonable VARCHAR size current 
size is too big,
   following column sizes are working with MySQL 5.6 and other databases and i 
believe they should be sufficient 
   
   ```
         "CREATE TABLE " + CATALOG_TABLE_NAME +
             "(" +
             CATALOG_NAME + " VARCHAR(255) NOT NULL," +
             TABLE_NAMESPACE + " VARCHAR(255) NOT NULL," +
             TABLE_NAME + " VARCHAR(255) NOT NULL," +
             METADATA_LOCATION + " VARCHAR(5500)," +
             PREVIOUS_METADATA_LOCATION + " VARCHAR(5500)," +
             "PRIMARY KEY (" + CATALOG_NAME + ", " + TABLE_NAMESPACE + ", " + 
TABLE_NAME + ")" +
             ")";
   ```
   
   tested your suggestion with Mysql, Postgresql, MsSQL databases and its 
working, feel free to open PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to