ismailsimsek commented on pull request #2778:
URL: https://github.com/apache/iceberg/pull/2778#issuecomment-872746858


   looks good, do you want o add second fix too ? 
   changing varchar size like below? 
   
   ```
         "CREATE TABLE " + CATALOG_TABLE_NAME +
             "(" +
             CATALOG_NAME + " VARCHAR(255) NOT NULL," +
             TABLE_NAMESPACE + " VARCHAR(255) NOT NULL," +
             TABLE_NAME + " VARCHAR(255) NOT NULL," +
             METADATA_LOCATION + " VARCHAR(5500)," +
             PREVIOUS_METADATA_LOCATION + " VARCHAR(5500)," +
             "PRIMARY KEY (" + CATALOG_NAME + ", " + TABLE_NAMESPACE + ", " + 
TABLE_NAME + ")" +
             ")";
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to