rdblue commented on a change in pull request #2800:
URL: https://github.com/apache/iceberg/pull/2800#discussion_r667554221
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -205,15 +219,20 @@ public StructType readSchema() {
// broadcast the table metadata as input partitions will be sent to
executors
Broadcast<Table> tableBroadcast =
sparkContext.broadcast(SerializableTable.copyOf(table));
- List<InputPartition<ColumnarBatch>> readTasks = Lists.newArrayList();
- for (CombinedScanTask task : tasks()) {
- readTasks.add(new ReadTask<>(
- task, tableBroadcast, expectedSchemaString, caseSensitive,
- localityPreferred, new BatchReaderFactory(batchSize)));
- }
- LOG.info("Batching input partitions with {} tasks.", readTasks.size());
+ List<CombinedScanTask> scanTasks = tasks();
+ InputPartition<ColumnarBatch>[] readTasks = new
InputPartition[scanTasks.size()];
- return readTasks;
+ Tasks.range(readTasks.length)
+ .stopOnFailure()
+ .executeWith(readTasksInitExecutorService)
+ .run(index -> {
Review comment:
The block is unnecessary because there is only one expression, can you
remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
