openinx commented on a change in pull request #2642:
URL: https://github.com/apache/iceberg/pull/2642#discussion_r667669697
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetUtil.java
##########
@@ -297,6 +297,10 @@ public static boolean
hasNonDictionaryPages(ColumnChunkMetaData meta) {
}
}
+ public static boolean hasNonBloomFilterPages(ColumnChunkMetaData meta) {
+ return meta.getBloomFilterOffset() == -1;
Review comment:
As the `getBloomFilterOffset` is marked as `Private` method, I would
prefer not to use it in the production files , in case of breaking the
compatibility when upgrading the parquet version in future.
Is there any other approach to check whether it generate bloom filter binary
or not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
