aokolnychyi commented on pull request #2810: URL: https://github.com/apache/iceberg/pull/2810#issuecomment-878725910
My primary motivation is the inconsistency we have in the code right now. In three actions (including `RemoveOrphanFiles`), we have `deleteWith` and `executeDeleteWith` methods that configure how to do the actual removal. We also use `deletedXXXCounts` in `ExpireSnapshots` to report the number of potentially physically removed files. Karuppayya's original implementation called the action `DeleteReachableFiles` and I asked to change that to use `remove` but I've changed my opinion after looking at the code a little bit more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
