nastra commented on a change in pull request #2588:
URL: https://github.com/apache/iceberg/pull/2588#discussion_r668672644
##########
File path: versions.props
##########
@@ -18,13 +18,11 @@ org.apache.arrow:arrow-memory-netty = 2.0.0
com.github.stephenc.findbugs:findbugs-annotations = 1.3.9-1
software.amazon.awssdk:* = 2.15.7
org.scala-lang:scala-library = 2.12.10
-org.projectnessie:* = 0.5.1
-javax.ws.rs:javax.ws.rs-api = 2.1.1
-io.quarkus:* = 1.13.1.Final
+org.projectnessie:* = 0.7.1-SNAPSHOT
Review comment:
assuming this will be updated with the proper release version
##########
File path:
nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java
##########
@@ -44,6 +45,15 @@ public boolean refresh() throws NessieNotFoundException {
return !oldReference.equals(reference);
}
+ public void updateReference(Reference ref) {
+ Objects.requireNonNull(ref);
+ if (this.reference != null && this.reference.getClass() != ref.getClass())
{
Review comment:
can `this.reference` ever be `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
