anuragmantri commented on issue #1617:
URL: https://github.com/apache/iceberg/issues/1617#issuecomment-880080917


   > Why not expose these methods instead:
   > 
   > // initialize the provider with the root paths and the `useRelativePath` 
config,
   > // or have different implementations like:
   > // - AbsoluteLocationProvider,
   > // - RelativeLocationProvider?
   > LocationProvider(Properties tableProperties);
   > 
   > // generate the absolute path for the metadata files
   > Path metaDataLocation(String file);
   > // generate the absolute path for the metadata files
   > Path dataLocation(String file);
   > 
   > // generate the value we put into the avro files - absolute or relative 
path
   > String metaDataKey(Path metadataFile);
   > // generate the value we put into the avro files - absolute or relative 
path
   > String dataKey(Path metadataFile);
   
   @pvary - This may make the code change larger. Other than that, I don't see 
why this cannot be done unless I'm missing something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to