rdblue commented on pull request #2849: URL: https://github.com/apache/iceberg/pull/2849#issuecomment-885001482
Looks good to me. I agree with the choice to detect cases where `hashString` can't be used since converting the string to bytes will allocate a new `ByteBuffer` and copy into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
