aokolnychyi commented on a change in pull request #2851:
URL: https://github.com/apache/iceberg/pull/2851#discussion_r675300959
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -262,7 +265,7 @@ WriteBuilder withWriterVersion(WriterVersion version) {
.build();
return new org.apache.iceberg.parquet.ParquetWriter<>(
Review comment:
You mean pass a context to `ParquetWriter`? I am not a huge fan of the
introduced context and I consider it very internal to `WriteBuilder` used to
create `FileAppender`. I think it is a good idea to avoid leaking it further.
Also, such writers have some sort of contexts already. For example,
`ParquetProperties` instantiated a few lines above covers some of the
properties but not all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
