openinx commented on a change in pull request #2854:
URL: https://github.com/apache/iceberg/pull/2854#discussion_r676261517
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -400,6 +404,7 @@ public final void initialize(String name,
CaseInsensitiveStringMap options) {
.toArray(new String[0]);
}
}
+ this.purgeDataAndMetadata = options.getBoolean(PURGE_DATA_AND_METADATA,
PURGE_DATA_AND_METADATA_DEFAULT);
Review comment:
We now have a `gc.enabled` property for the similar behavior (
https://github.com/apache/iceberg/pull/1796), could we introduce the existing
property to this spark catalog ? Sounds like the `gc.enabled=false` will keep
all the data files but still remove the metadata files while what you expected
is keep both the data files and metafiles..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
