rdblue commented on a change in pull request #2826: URL: https://github.com/apache/iceberg/pull/2826#discussion_r676752903
########## File path: build.gradle ########## @@ -174,7 +175,7 @@ project(':iceberg-bundled-guava') { shadowJar { classifier null - configurations = [project.configurations.compileOnly] + configurations = [project.configurations.compileClasspath] Review comment: Is this correct? We include `compileOnly` to avoid including `compile` or `implementation` dependencies that are expected in the runtime classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org