jackye1995 commented on a change in pull request #2858:
URL: https://github.com/apache/iceberg/pull/2858#discussion_r676802730
##########
File path: core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
##########
@@ -95,25 +100,71 @@ public OutputFileFactory(PartitionSpec spec, FileFormat
format, LocationProvider
this.operationId = operationId;
}
+ public static Builder builderFor(Table table, FileFormat format, int
partitionId, long taskId) {
Review comment:
+1 for having default file format from the table properties, so that
when `write-format` option is not set it can default to the table default
instead of finding it again and pass it to the call.
And btw it's probably a good idea to have a util method to get the file
format from the properties map, since we are doing it everywhere, but no need
to have that in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
