aokolnychyi commented on a change in pull request #2873:
URL: https://github.com/apache/iceberg/pull/2873#discussion_r677024412
##########
File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
##########
@@ -321,6 +321,8 @@ public DataWriteBuilder withSortOrder(SortOrder
newSortOrder) {
public <T> DataWriter<T> build() throws IOException {
Preconditions.checkArgument(spec != null, "Cannot create data writer
without spec");
+ Preconditions.checkArgument(spec.isUnpartitioned() || partition != null,
Review comment:
Extra validation I originally had in the write factory impl but I think
it makes sense to move it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
