openinx commented on a change in pull request #2865:
URL: https://github.com/apache/iceberg/pull/2865#discussion_r677083552
##########
File path: core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
##########
@@ -312,6 +312,7 @@ static Builder builderFor(FileIO io, Iterable<ManifestFile>
deleteManifests) {
static class Builder {
private final FileIO io;
private final Set<ManifestFile> deleteManifests;
+ private long minSequenceNumber = 0L;
Review comment:
I remember the sequence number 0 is kept for the data files for iceberg
v1, so in theory the sequence number from delete files should start from 1.
So setting it to 0 as the default value sounds correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
