aokolnychyi commented on a change in pull request #2873: URL: https://github.com/apache/iceberg/pull/2873#discussion_r677130061
########## File path: core/src/main/java/org/apache/iceberg/io/WriterFactory.java ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.deletes.EqualityDeleteWriter; +import org.apache.iceberg.deletes.PositionDeleteWriter; +import org.apache.iceberg.encryption.EncryptedOutputFile; + +/** + * A factory for creating data and delete writers. + */ +public interface WriterFactory<T> { + + /** + * Creates a new {@link DataWriter}. + * + * @param file the output file + * @param spec the partition spec written data belongs to + * @param partition the partition written data belongs to or null if the spec is unpartitioned + * @return the constructed data writer + */ + DataWriter<T> newDataWriter(EncryptedOutputFile file, PartitionSpec spec, StructLike partition); + + /** + * Creates a new {@link EqualityDeleteWriter}. + * + * @param file the output file + * @param spec the partition spec written deletes belong to + * @param partition the partition written deletes belong to or null if the spec is unpartitioned Review comment: Ideally, we would have an extra method without the spec and partition. However, we did not reserve any particular spec ID as unpartitioned. That's why we still need a correct spec even for unpartitioned writes as we need to store a correct spec ID in the metadata. We could offer a method without the partition struct but I am not sure how valuable that is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
