yyanyy opened a new pull request #2878:
URL: https://github.com/apache/iceberg/pull/2878
- Noticed that we have not closed all resources that we could when we close
Glue/DynamoDB based catalog
- In order to close all resources, `S3FileIO` may need to be updated too
since it holds a reference to S3 client.
- I believe only `S3FileIO` would actually need it for now but made
`FileIO` to be closeable since I think other cloud services may also need it
once they are supported
- Extend `CloseableGroup` to be configurable and support close failure
suppression, leave default suppression behavior to false for backward
compatibility, and added tests
- Didn't update other catalog other than aws ones since they usually only
need to close one resource, that overriding `close` should be sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
