openinx commented on a change in pull request #2873: URL: https://github.com/apache/iceberg/pull/2873#discussion_r677930213
########## File path: data/src/main/java/org/apache/iceberg/data/BaseWriterFactory.java ########## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.data; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.Map; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.MetricsConfig; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Schema; +import org.apache.iceberg.SortOrder; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.Table; +import org.apache.iceberg.avro.Avro; +import org.apache.iceberg.deletes.EqualityDeleteWriter; +import org.apache.iceberg.deletes.PositionDeleteWriter; +import org.apache.iceberg.encryption.EncryptedOutputFile; +import org.apache.iceberg.encryption.EncryptionKeyMetadata; +import org.apache.iceberg.io.DataWriter; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.io.WriterFactory; +import org.apache.iceberg.orc.ORC; +import org.apache.iceberg.parquet.Parquet; + +/** + * A base writer factory to be extended by query engine integrations. + */ +public abstract class BaseWriterFactory<T> implements WriterFactory<T> { + private final Table table; + private final FileFormat dataFileFormat; + private final Schema dataSchema; + private final SortOrder dataSortOrder; + private final FileFormat deleteFileFormat; + private final int[] equalityFieldIds; + private final Schema equalityDeleteRowSchema; + private final SortOrder equalityDeleteSortOrder; + private final Schema positionDeleteRowSchema; + private final SortOrder positionDeleteSortOrder; + + protected BaseWriterFactory(Table table, FileFormat dataFileFormat, Schema dataSchema, + SortOrder dataSortOrder, FileFormat deleteFileFormat, + int[] equalityFieldIds, Schema equalityDeleteRowSchema, + SortOrder equalityDeleteSortOrder, Schema positionDeleteRowSchema, + SortOrder positionDeleteSortOrder) { + this.table = table; Review comment: Since `table` is a mutable instance and its lifecycle is binded to the catalog connection's lifecycle. Take hive catalog as an example, If someone create a table like the following: ```java Table table; try(Catalog catalog = loadCatalog){ table = catalog.loadTable(...); } ``` And then we pass the `table` through the writer path, what concern me is people may use this table instance to access the latest table state (for example `table.refresh()` to get the latest partition spec or SortOrder etc) for their purpose - which will lead to the interruption as the catalog catalog has been closed. That's why we did not introduce pass an iceberg `Table` to the underlying writer path because it's hard to check whether the catalog connection has been closed or not. So I recommend to just pass the detailed parameters that we need to construct the delete/data writers, such as table properties, schema, partitionSpec, sortOrder etc, rather than providing a whole `Table` instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
