openinx commented on a change in pull request #2364:
URL: https://github.com/apache/iceberg/pull/2364#discussion_r678124432
##########
File path: core/src/main/java/org/apache/iceberg/util/TableScanUtil.java
##########
@@ -64,4 +77,21 @@ public static boolean hasDeletes(FileScanTask task) {
splitFiles),
BaseCombinedScanTask::new);
}
+
+ public static Map<StructLikeWrapper, Collection<FileScanTask>>
groupTasksByPartition(
+ PartitionSpec spec,
Review comment:
I don't think it's correct to use the table latest partition spec to
group the `FileScanTask`, because different `FileScanTask` many have
different partition specs, the correct way is to use the `FileScanTask#spec`
to group the tasks. We should remove the `spec` as an argument, otherwise it
introducing a bug...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
