openinx commented on a change in pull request #2887:
URL: https://github.com/apache/iceberg/pull/2887#discussion_r678776709
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -47,6 +47,19 @@
* Metadata for a table.
*/
public class TableMetadata implements Serializable {
+
+ /**
+ * Iceberg always use the latest stable format version when creating a new
table.
+ * This reserved property keyword allows users to override the Iceberg
format version of the table metadata.
+ * <p>
+ * If this table property exists when creating a table, the table will use
the specified format version.
+ * If a table updates this property, it will try to upgrade to the specified
format version.
+ * This helps developers to try out new features in an unreleased version or
migrate existing tables to a new version.
+ * <p>
+ * Note: If you set the Iceberg format to an unreleased version, software
stability is not guaranteed.
+ */
+ public static final String PROPERTY_FORMAT_VERSION = "format-version";
Review comment:
Do we miss to override the default format version to be 2 in the
[replaceTransaction](https://github.com/apache/iceberg/blob/21e1922a8ddb93a82388ea86a5f500d9f23885b3/core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java#L256)
code path ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
